Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base microbatch support + tests #300

Merged
merged 10 commits into from
Sep 11, 2024
Merged

base microbatch support + tests #300

merged 10 commits into from
Sep 11, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 10, 2024

resolves #302
docs dbt-labs/docs.getdbt.com/# N/A

Problem

We need a base built-in microbatch incremental strategy implementation!

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 10, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk marked this pull request as ready for review September 11, 2024 18:18
@MichelleArk MichelleArk requested a review from a team as a code owner September 11, 2024 18:18
QMalcolm
QMalcolm previously approved these changes Sep 11, 2024
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 🇮🇹

@MichelleArk MichelleArk merged commit 629f22f into main Sep 11, 2024
15 checks passed
@MichelleArk MichelleArk deleted the base-microbatch-tests branch September 11, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Default microbatch strategy implementation + testing in dbt-adapters
3 participants